tr1|tr2/objects/door: reset sector tilt on closed doors #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy approach would reset the FD index to 0, but this was missed in the FD refactor in LostArtefacts#1433. The result was NO_HEIGHT would be manipulated by the tilt values and hence could produce invisible geometry.
The legacy approach would reset the FD index to 0, but this was missed in the FD refactor in LostArtefacts#1896. The result was NO_HEIGHT would be manipulated by the tilt values and hence could produce invisible geometry.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
aredfan
approved these changes
Nov 26, 2024
rr-
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1958.
Checklist
Description
Before the FD refactor in both games, closing a door would reset the sector FD index to 0, and so that meant functions such as
Room_GetCeilingwould not interpret tilt values. I missed applying the equivalent reset in both #1433 and #1896 and so the result was thatNO_HEIGHTvalues would be adjusted with tilt values, and hence produce something other thanNO_HEIGHTand therefore potential invisible geometry.Quite specific still for the issue itself: you need a door that's not on a portal sector in a room above, and there must be tilt geometry defined. This doesn't happen in OG TR1 AFAIK, so I've attached a test level.
level1.zip