Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr2/data: add pickup item rotation injections #1972

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Nov 29, 2024

Resolves #1613.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This adds injections to rotate pickup items to better suit 3D pickup mode.

Ref: LostArtefacts/TRXInjectionTool#14

This adds injections to rotate pickup items to better suit 3D pickup
mode.

Resolves LostArtefacts#1613.
@lahm86 lahm86 added Feature New functionality Data Requires injecting content / files that are not a part of the original game TR2 labels Nov 29, 2024
@lahm86 lahm86 self-assigned this Nov 29, 2024
@lahm86 lahm86 requested review from a team as code owners November 29, 2024 21:10
@lahm86 lahm86 requested review from rr-, walkawayy and aredfan and removed request for a team November 29, 2024 21:10
@lahm86
Copy link
Collaborator Author

lahm86 commented Nov 29, 2024

@aredfan Thank you for going through all the levels and marking these up. I've marked this as resolving the issue, I figured we could raise a separate task for GM to keep versioning in line. LMK if you think that's OK.

Copy link

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahm86 It's my pleasure, and thank you for diligently implementing this feature. All the rotated pickups LGTM.👍

I agree that GM pickups should be tackled in a separate issue.

@lahm86 lahm86 merged commit ae24a69 into LostArtefacts:develop Nov 30, 2024
6 checks passed
@lahm86 lahm86 deleted the issue-1967-tr2-item-rots branch November 30, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Requires injecting content / files that are not a part of the original game Feature New functionality TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature request: Rotate 3D pickups
3 participants