TR2: add user controllable FOV

[rr-]

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change
• I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

I chose to always apply the vertical FOV instead of making it a setting like in TR1. Instead, I included TR2Main's PCX FOV feature. This is primarily important for the inventory ring and cutscenes, which have fixed FOV values that players can't adjust themselves. I've been careful not to break the cutscenes, but it would be helpful to have them reviewed.

[github-actions]

Download the built assets for this pull request:

• TR1X-4.7.1-214-g80c391a-linux.zip
• TR1X-4.7.1-214-g80c391a-win.zip
• TR1X-4.7.1-214-g80c391a-win-installer.zip
• TR2X-0.7.1-273-g80c391a-win.zip
• TRX-4.7.1-214-g80c391a-mac.zip

[Richard-L]

Will try to do more testing after some sleep, but:

• What's TR2Main's PCX feature?
• Is there, or do you plan to enable, a way from the config tool, or in-game sunglasses settings, to set the PS1 FOV? This new FOV in the build is a definite improvement, but the ring menu and Lara with weapon equipped feel rather tiny to my PS1 eyes.

[rr-]

Will try to do more testing after some sleep, but:

• What's TR2Main's PCX feature?

It slightly enlarges the game by using a different height option. I recommend enabling this.

• Is there, or do you plan to enable, a way from the config tool, or in-game sunglasses settings, to set the PS1 FOV?

I read this as two questions, re: better UI – yes this is #1615, re: PS1 FOV – why not? But please do try the PCX FOV and LMK if it's different, ideally with screenshots of the title screen.

[aredfan]

Looks great! Thank you. 👍

[aredfan]

I did end up finding an issue after all. It's possible for the /set pcx command to stop working after Lara uses a key on a keyhole. It can also happen with a puzzle hole.

1. /play 12
2. /tp keyhole
3. use the all items cheat
4. use the key
5. /set pcx 0 or /set pcx 1

[Richard-L]

How do you enable PCX?

Did I miss it in the config tool?

[rr-]

How do you enable PCX?

Did I miss it in the config tool?

For now, no UI for this – /set or the config file. I'll add that to the changelog.
It won't make its way to the config tool – it's supposed to be easily changeable from the game, and we'll get to that in #1615 but I cannot work on everything at once.

[lahm86]

Looks great. My only thought would be to make the pcx setting enabled by default.

[rr-]

@aredfan @lahm86 fixed.
Also, found an issue where 3D pickups would pick up user FOV, which for extreme values would look really off. Fixed that as well.

I changed the order of the inventory ring initialization so it'd be good to test its interaction with game music, the spinout sound, and other side effects.

[Richard-L]

For now, no UI for this – /set or the config file. I'll add that to the changelog. It won't make its way to the config tool – it's supposed to be easily changeable from the game, and we'll get to that in #1615 but I cannot work on everything at once.

There's still no table anywhere with all possible console commands is there? I tried a couple and after some failures worked out how to turn PCX on/off. On seems to look like OG?

I also tried to set the FOV to 60 like you can in TR1X' config file, but I didn't manage to guess the right console command here.

Tbh the console is a little frustrating due to the intended guesswork, and due to it not being possible to type / on my keyboard. But it seems to work without it still.

[walkawayy]

Here's all the commands. Looks like the FOV one isn't in there yet though.

https://github.com/LostArtefacts/TRX/blob/develop/docs/tr2/COMMANDS.md

[Richard-L]

Thanks a lot, that's helpful.

[rr-]

Here's all the commands. Looks like the FOV one isn't in there yet though.

https://github.com/LostArtefacts/TRX/blob/develop/docs/tr2/COMMANDS.md

The command for it is called /set, I'll add it to the documentation.