Inventory ring work

[rr-]

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change
• I have added a readme entry about my new feature or OG bug fix, or it is a different change

Scope of the changes

• Cleans up inventory ring types
• Moves about a half of the inventory ring code to libtrx
• Introduces INV_RING_SOURCE to maintain individual ring item lists
• Re-separates the TR1 inventory ring code from the inventory phaser (merging them together was a mistake)
• Reaches acceptable code similarity between TR1 and TR2
• Rewrites TR1 inventory phase to use the new executor flow
• Updates the phase executor to deal with interpolation
• Moves the most basic interpolation APIs to libtrx
• Introduces an annoying boolean g_GameInfo.inv_ring_shown to deal with health bar occluding the FPS counter in TR1
• Fixes OG bug: arrows visible during quick save even with no keys #2225

What's left

• Rework the new fader to play nice with 60 FPS (it's terrible atm, so this PR keeps the old APIs.)
• Rework fade effects in the inventory phaser to use the fader API.
• Merge the inventory ring phasers from TR1 and TR2.
• Later, merge remaining inventory code, which is currently full of small differences (control and draw routines).
• Eventually, rewrite the overlay module to finally use the UI and its layout capabilities, or at least add a way to show/hide widgets given a widget enum. Kill some of the GAME_INFO members.

Testing

Inventory ring:

• animations
• fade effects
• game flow behavior
• executing game flow commands in the inventory and outside of it
• exiting the inventory in any way you can imagine - to the title screen and to various game contexts
• passport meshes
• cycling between different rings
• equipping guns
• consuming medpacks/flares
• consuming puzzle items by interacting with the keyhole with the action key
• consuming puzzle items by going to the menu manually
• examining items (Lahm's recent work)
• trying to use keyholes without a key
• inventory ring UIs (save game, load game dialog, assault course stats, compass, stopwatch)
• equipping guns via inventory etc
• turbo speed and how it affects animations and the compass needle
• 30/60 FPS and how it affects animations and the compass needle
• health bars / FPS counter / arrows occlusion
• etc…

Others:

• TR1 and TR2 cutscene sync over time (since we did change the executor)

[github-actions]

Download the built assets for this pull request:

• TR1X-4.7.1-313-g54acc53-linux.zip
• TR1X-4.7.1-313-g54acc53-mac.zip
• TR1X-4.7.1-313-g54acc53-win.zip
• TR1X-4.7.1-313-g54acc53-win-installer.zip
• TR2X-0.8-91-g54acc53-linux.zip
• TR2X-0.8-91-g54acc53-win.zip

[aredfan]

I found this TR1 issue while testing, which is ongoing.

• You can hear Lara speaking after loading a save or exiting to title, with these steps.

1. have a savegame ready
2. /set music-in-inventory 0
3. /play 0
4. when Lara is speaking, press F6
5. load a savegame
6. when the ring closes, you can hear Lara's voice for a brief moment

This issue also happens if you open the inventory and select a loadgame, or exit to title.

Edit: Testing is done, no more issues found. 👍

[rr-]

Thank you @aredfan! Fixed.