Move pause phase to libtrx; add pause dialog to TR2 #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
rr-
force-pushed
the
fader-improvements
branch
2 times, most recently
from
ab74e45 to
49fd51c
Compare
rr-
force-pushed
the
trx-pause
branch
2 times, most recently
from
a1e8888 to
c47bc90
Compare
rr-
force-pushed
the
fader-improvements
branch
from
3031ae7 to
d9cbc33
Compare
|
|
@aredfan updated. |
lahm86
reviewed
Jan 8, 2025
aredfan
approved these changes
Jan 8, 2025
|
@lahm86 addressed all remarks. |
Fixes flares not freezing when they should.
lahm86
approved these changes
Jan 8, 2025
|
@rr- When you load a game there is no fade when the inventory menu animates in. |
2025-01-09.00-56-03.mp4"Paused" shouldn't show until the fade is at 100%. Also the fade is a few milliseconds too long (?) compared to OG in video above. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR builds on top of #2232 and moves the pause phase – which already utilizes the new phase API – to libtrx, and backports it to TR2. Fortunately, there weren't many missing dependencies, which made the transition pretty straightforward. I've added is a fade-out effect to ensure a smooth transition when the player exits the pause screen, whether by alt+f4, navigating through the UIs, or simply pressing the pause key again. Plus, I've made it flexible for players to rebind the pause key, which is set to P by default.
Testing
We only need to test general interaction with the pause screen (including exiting the game through alt+f4) in both TR1 and TR2 with fade effects on and off.
I'm aware that the fade-out transitions when exiting the game aren't consistent for TR1 right now, but we'll fix that once we consolidate more phases.