Add photo mode to TR2

[rr-]

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change
• I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

Resolves #2277.

The controls UI got bloated – we'll address it later.
I added a couple of ugly #if TR_VERSION throughout the photo mode code, but that's because the viewport module APIs are fundamentally different in both games for now.
I reduced the flicker when capturing the screenshot to minimum, and added a fade-out effect when exiting the game while in photo mode (TR2 only).

[github-actions]

Download the built assets for this pull request:

• TR1X-4.7.1-411-g416ed43-linux.zip
• TR1X-4.7.1-411-g416ed43-mac.zip
• TR1X-4.7.1-411-g416ed43-win.zip
• TR1X-4.7.1-411-g416ed43-win-installer.zip
• TR2X-0.8-189-g416ed43-linux.zip
• TR2X-0.8-189-g416ed43-win.zip

[lahm86]

Looks great overall 👍

• The camera is too high during starting animations (Rig and HSH). Other in-game cinematics seem OK (dagger pull, shower)
• Should we change the default input to F11 in TR1 to match?

[rr-]

Looks great overall 👍

• The camera is too high during starting animations (Rig and HSH). Other in-game cinematics seem OK (dagger pull, shower)

Fixed, but it'll be good to have this thoroughly rechecked.

• Should we change the default input to F11 in TR1 to match?

Oh yeah I forgot to ask about this. I wouldn't touch TR1 TBH, and instead, I'd remap TR2 controls. WDYT? For example something like this:

INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_PAUSE,                       SDL_SCANCODE_P)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_UI,                   SDL_SCANCODE_H)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_PHOTO_MODE,           SDL_SCANCODE_F1)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_BILINEAR_FILTER,      SDL_SCANCODE_F3)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_PERSPECTIVE_FILTER,   SDL_SCANCODE_F4)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_FULLSCREEN,           SDL_SCANCODE_UNKNOWN)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_Z_BUFFER,             SDL_SCANCODE_F7)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_CYCLE_LIGHTING_CONTRAST,     SDL_SCANCODE_F8)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_SWITCH_INTERNAL_SCREEN_SIZE, SDL_SCANCODE_F10)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_SWITCH_RESOLUTION,           SDL_SCANCODE_F11)
INPUT_KEYBOARD_ASSIGN(INPUT_ROLE_TOGGLE_RENDERING_MODE,       SDL_SCANCODE_F12)

[lahm86]

Remapping TR2 inputs as above sounds ideal 👍

[rr-]

Updated the bindings.

[aredfan]

Looks great! Just 2 issues to report:

• The camera ends up in an odd position if pause is used during cutscenes.
• It looks like photo mode isn't usable in cutscenes.

[rr-]

@aredfan both fixed. I might've introduced one-frame-off glitches with the game camera and/or with the cutscenes, though.

[aredfan]

@aredfan both fixed. I might've introduced one-frame-off glitches with the game camera and/or with the cutscenes, though.

Thank you. 👍

I found a couple of bugs in cutscenes.

Cutscene 2 in PR build:

Cutscene 3 in PR build:

Cutscene 3 in dev snapshot:

[rr-]

Thank you @aredfan for the patience – I only tested cutscene 1. Thanks to Lahm's fix it should be fixed now.