Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements and fixes #468

Merged
merged 104 commits into from
May 6, 2023
Merged

Some improvements and fixes #468

merged 104 commits into from
May 6, 2023

Conversation

mr-manuel
Copy link
Collaborator

@mr-manuel mr-manuel commented Feb 17, 2023

- added missing descriptions
- changed name
@mr-manuel mr-manuel changed the title Added balancing switch status for JKBMS Some improvements Feb 17, 2023
@mr-manuel mr-manuel changed the title Some improvements Some improvements and fixes Feb 20, 2023
should be None instead of 0, if not available
- Added: Show TimeToSoc only, if enabled
- Changed: description in config file
- Changed: default value TIME_TO_SOC_VALUE_TYPE = 1
- changed: how often Time-To-Soc is calculated in seconds
- changed: Time-To-Go has to be always a positive int
since it's used from dbus-systemcalc-py
- changed: how Time-to-SoC is string is generated and displayed
(format like Time-To-Go)
respecting semantic versioning
- `/data/conf/serial-starter.d` was not recreated if deleted
- added description in utils.py
- change qml files in destination not source
Copy link

@math322 math322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you work with config files again. Wouldn't it be better to use the victron dbus service to store non volatile settings?

https://github.com/victronenergy/localsettings

@mr-manuel
Copy link
Collaborator Author

@math322 in this case there has to be a GUI where you can set all the settings and therefore complicate things. The config file is meant to set once all options and then you don't need to chage them again, except for optimization tweaking. But this is only my opinion.

@math322
Copy link

math322 commented Mar 13, 2023

I checked the default path (used in the scripts) of the user config.ini and the config.default.ini but the config.ini got vanished in some circumstances by some scripts and the folder got re-created from the /data path, but there is no config.ini, so the user config.ini is deleted by definition. Is this the wanted behavior?

@mr-manuel
Copy link
Collaborator Author

You mean, when run installlocal.sh or installrelease.sh and the tar is extracted over the existing folder the config.ini gets deleted?

The default behaviour should be that the driver is shipped without config.ini and the config.ini should not be edited/deleted by the driver.

@mr-manuel mr-manuel marked this pull request as ready for review May 2, 2023 20:04
@mr-manuel mr-manuel requested a review from Louisvdw May 2, 2023 20:32
@mr-manuel
Copy link
Collaborator Author

PR is ready to be merged!

@Louisvdw Louisvdw merged commit e762832 into Louisvdw:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daly bms sleep mode causing incorrect data in MP2 gx webinterface
6 participants