-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements and fixes #468
Conversation
- added missing descriptions - changed name
should be None instead of 0, if not available
- Added: Show TimeToSoc only, if enabled - Changed: description in config file - Changed: default value TIME_TO_SOC_VALUE_TYPE = 1
- changed: how often Time-To-Soc is calculated in seconds
- changed: Time-To-Go has to be always a positive int since it's used from dbus-systemcalc-py - changed: how Time-to-SoC is string is generated and displayed (format like Time-To-Go)
Pull request from @baphomett Louisvdw/dbus-serialbattery#440
respecting semantic versioning
- `/data/conf/serial-starter.d` was not recreated if deleted
- added description in utils.py - change qml files in destination not source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you work with config files again. Wouldn't it be better to use the victron dbus service to store non volatile settings?
@math322 in this case there has to be a GUI where you can set all the settings and therefore complicate things. The config file is meant to set once all options and then you don't need to chage them again, except for optimization tweaking. But this is only my opinion. |
I checked the default path (used in the scripts) of the user config.ini and the config.default.ini but the config.ini got vanished in some circumstances by some scripts and the folder got re-created from the /data path, but there is no config.ini, so the user config.ini is deleted by definition. Is this the wanted behavior? |
You mean, when run The default behaviour should be that the driver is shipped without |
PR is ready to be merged! |
on changes in master or docusaurus branch
FLOAT_CELL_VOLTAGE from 3.350V to 3.375V LINEAR_LIMITATION_ENABLE from False to True
* on disconnect, show '---' after 10s and 'not connected' after 60s by @transistorgit * small fixes in shell script * added restart driver script
before float voltage was applied
* Choose to block charge/discharge on disconnect * Trigger Venus OS alarm
* show self.unique_identifier as serial number * show self.production as device name
this adds the battery production date
self.unique_identifier
to the battery class. Used to identify a BMS when multiple BMS are connected - planned for future use by @mr-manuelCVCM_ENABLE
isFalse
. Before float voltage was applied by @mr-manuelconfig.ini
for easier user usage by @mr-manuelreinstall-local.sh
to recreate/data/conf/serial-starter.d
, if deleted bydisable.sh
--> to check if the fileconf/serial-starter.d
could now be removed from the repository by @mr-manuelrestore-gui.sh
by @mr-manueldefault_config.ini
toconfig.default.ini
Make things configurable #412 (comment) by @mr-manuelTIME_TO_SOC_VALUE_TYPE
fromBoth seconds and time string "<seconds> [<days>d <hours>h <minutes>m <seconds>s]"
to1 Seconds
by @mr-manuelTIME_TO_SOC_VALUE_TYPE
is set to other than1
TimeToGo #424 (comment) by @mr-manuelreinstall-local.sh
. Fixes also serial-starter config should not be called serial-starter.d #520 by @mr-manuelTIME_TO_SOC_LOOP_CYCLES
toTIME_TO_SOC_RECALCULATE_EVERY
by @mr-manueldays, HR:MN:SC
to<days>d <hours>h <minutes>m <seconds>s
(same as Time-To-Go) by @mr-manuel