Change line color range and rendering order (microsoft#2759)

LovPe · Aug 7, 2020 · 654e824 · 654e824
1 parent 214a8e1
commit 654e824
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/src/webui/src/components/trial-detail/Para.tsx b/src/webui/src/components/trial-detail/Para.tsx
@@ -162,21 +162,32 @@ class Para extends React.Component<ParaProps, ParaState> {
             const scale = this.convertToD3Scale(v);
             if (k === primaryMetricKey && scale !== undefined && scale.interpolate) {
                 // set color for primary metrics
-                colorScale = this.convertToD3Scale(v, false)
-                    .range(['green', 'red'])
-                    .interpolate(d3.interpolateHsl);
-                colorDim = k;
+                // `colorScale` is used to produce a color range, while `scale` is to produce a pixel range
+                colorScale = this.convertToD3Scale(v, false);
+                convertedTrials.sort((a, b) => EXPERIMENT.optimizeMode === 'minimize' ? a[k] - b[k] : b[k] - a[k]);
                 // filter top trials
                 if (percent != 1) {
                     const keptTrialNum = Math.max(Math.ceil(convertedTrials.length * percent), 1);
-                    convertedTrials.sort((a, b) => EXPERIMENT.optimizeMode === 'minimize' ? a[k] - b[k] : b[k] - a[k]);
                     convertedTrials = convertedTrials.slice(0, keptTrialNum);
                     const domain = d3.extent(convertedTrials, item => item[k]);
                     scale.domain([domain[0], domain[1]]);
+                    colorScale.domain([domain[0], domain[1]]);
                     if (colorScale !== undefined) {
                         colorScale.domain(domain);
                     }
                 }
+                // reverse the converted trials to show the top ones upfront
+                convertedTrials.reverse();
+                const assignColors = (scale: any): void => {
+                    scale.range([0, 1]);  // fake a range to perform invert
+                    const [scaleMin, scaleMax] = scale.domain();
+                    const pivot = scale.invert(0.5);
+                    scale.domain([scaleMin, pivot, scaleMax])
+                        .range(['#90EE90', '#FFC400', '#CA0000'])
+                        .interpolate(d3.interpolateHsl);
+                };
+                assignColors(colorScale);
+                colorDim = k;
             }
             dimensions.push([k, {
                 type: 'number',