refactor: Remove internal uses of the .first() and .matchCondition() helpers
#889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those are just helper functions for a better dev exp really, so we won't be deprecating them (and sadly, I have some projects with thousands of lines that rely on these :p, it would be a pain to refactor that.) I do agree that we shouldn't use them internally though. |
LuanRT
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As those
ObservedArrayhelpers are just thin wrappers around[0]and.find()respectively. Using the original versions should be slightly faster and uses slightly less code, without losing any functionality.It might be worth deprecating the
.first(),.matchCondition()and.remove()helpers, because they all are just thin wrappers that don't provide any additional functionality than just interacting with the array yourself directly. Removing them straight away might break users code, hence the suggestion to deprecate them first.