Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Parser): parse all contents in home tab #891

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ChunkyProgrammer
Copy link
Contributor

This is a bit strange but it seems that the home pages on some channels(ex: https://www.youtube.com/channel/UC-9-kyTW8ZkZNDHQJ6FgpwQ ) have multiple different List/Grid renderers in the same object (not an array) so this PR allows for parsing them.

To be decided/further questions:
Is this the proper way to parse multiple items like this?
Should content get removed for contents since it could contain an empty sectionList (like the music channel for example)? Or should we keep both properties (this wouldn't be a breaking change but might cause confusion because of potential duplication)

@LuanRT
Copy link
Owner

LuanRT commented Feb 13, 2025

Is there any channel where these extra renderers have any content? You provided the YouTube Music channel, but it only contains an empty renderer, as you noted.

Also, I've noticed that on m.youtube.com, that section list is populated and disablePullToRefresh is true (and this field is also present on that empty renderer on desktop, but it being there makes no sense), so perhaps this is a bug on YouTube's side?

@ChunkyProgrammer
Copy link
Contributor Author

I haven't found any other channels like this but i also wasn't looking for any.

@ChunkyProgrammer
Copy link
Contributor Author

I'll take a look at doing this a different way since we don't need to care about empty renderers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants