Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to disable the TUI #432

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Dec 21, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

I don't think any users would ever want to do this, but it's helpful in dev when iterating and only the CLI is needed. Should speed up compilation a bit.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

A user could be confused by this. Mitigated by having it enabled by default, and not documenting it so I doubt anyone will come across it other than in the Cargo.toml.

QA

How did you test this?

manually

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

I don't think any users would ever want to do this, but it's helpful in dev when iterating and only the CLI is needed. Should speed up compilation a bit.
@LucasPickering LucasPickering merged commit b7e68a7 into master Dec 21, 2024
15 checks passed
@LucasPickering LucasPickering deleted the tui-feature-flag branch December 21, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant