-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REST Importer for Jetbrains / VSCode #435
Add REST Importer for Jetbrains / VSCode #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This is looking great, just some formatting/readability comments mostly. I'm going to push one commit with some small changes I made to the docs, I figured it would be easier than trying to explain.
There are some formatting and lint issues as well, they'll show up in the CI once I kick it off.
Thanks for your work on this!
Cool, I think these changes address everything mentioned. Now I just have to figure out the linters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more suggestions but it's looking good! For the formatting you can run cargo fmt
locally, for linting cargo clippy
will show you the errors.
There we go! That should be everything. I got the linter and formatter happy too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! This will go out in 2.5.0, which will probably be next week some time.
e061773
to
5b96fb5
Compare
Description
A few months ago I filed a pull request to add this in but I got busy so it ended up getting closed. (Addresses this) Anyway, I'm back and decided to reintegrate it! Here is the previous closed issue with more details: #205
I made the REST Parser a separate crate because it was quite complex and would be useful for other projects as well. You can check it out here: https://github.com/benfaerber/rest_parser
The old version had a Jetbrains environment loading feature which I did not include because it added a ton of complexity and not too much benefit.
Import using:
Known Risks
QA
Lots of unit tests in
rest.rs
and some test data.Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?