Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gifs again #441

Merged
merged 2 commits into from
Jan 2, 2025
Merged

More gifs again #441

merged 2 commits into from
Jan 2, 2025

Conversation

LucasPickering
Copy link
Owner

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

  • Move doc gifs to docs/src/images/
  • Re-enable print mode (should work now that we're just using relative URLs for images again)
  • Load GIF path from tape file instead of guessing it
  • Add gif for response querying, instead of the two (very) old screenshots

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

QA

How did you test this?

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) January 2, 2025 17:38
@LucasPickering LucasPickering merged commit c63da9f into master Jan 2, 2025
15 checks passed
@LucasPickering LucasPickering deleted the more-gifs-again branch January 2, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant