Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor view state #444

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Refactor view state #444

merged 1 commit into from
Jan 3, 2025

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Jan 3, 2025

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

This refactors the exchange pane and it's children to be single-use, meaning we trash the component and build a new one whenever the request state changes. This makes the state management much simpler. I'd like to move toward this pattern more in general.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

State bugs. We have decent test coverage to guard against this.

QA

How did you test this?

Bit of manual testing, mostly relying on existing tests

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering changed the base branch from master to 3.0 January 3, 2025 19:02
This refactors the exchange pane and it's children to be single-use, meaning we trash the component and build a new one whenever the request state changes. This makes the state management much simpler. I'd like to move toward this pattern more in general.
@LucasPickering LucasPickering enabled auto-merge (rebase) January 3, 2025 19:08
@LucasPickering LucasPickering merged commit 218b2dd into 3.0 Jan 3, 2025
15 checks passed
@LucasPickering LucasPickering deleted the refactor-view-state branch January 3, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant