Use single-threaded runtime in tokio #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
Generally there is very low CPU and I/O utilization by Slumber, so there's no benefit in distributing work over multiple tasks. Uses a single thread should cut down on wasted context switches, and also allow for simplifying code by eliminating the need for the mpsc message queue.
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
If someone is trying to send a ton of requests at once, it's possible we start to become CPU-bound by the single thread. I think this is very unlikely though. We could always switch back to multi-threading if necessary.
QA
How did you test this?
Manually ran tests and reloaded collection in the TUI
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?