[Electric-Coin-Company#1452] TX Resubmission-the wallet has to period…

…ically resubmit unmined transactions (Electric-Coin-Company#1454)

- State machine puml and png files updated
- Order of transaction removed because it has no effect

Sources/ZcashLightClientKit/Block/Actions/TxResubmissionAction.swift

@@ -34,7 +34,7 @@ extension TxResubmissionAction: Action {
         do {
             logger.info("TxResubmissionAction check started at \(latestBlockHeight) height.")
             let transactions = try await transactionRepository.findForResubmission(upTo: latestBlockHeight)
-                        
+
             // no candidates, update the time and continue with the next action
             if transactions.isEmpty {
                 latestResolvedTime = Date().timeIntervalSince1970

Sources/ZcashLightClientKit/DAO/TransactionDao.swift

@@ -110,7 +110,6 @@ class TransactionSQLDAO: TransactionRepository {
 
     func findForResubmission(upTo: BlockHeight) async throws -> [ZcashTransaction.Overview] {
         let query = transactionsView
-            .order((ZcashTransaction.Overview.Column.minedHeight ?? BlockHeight.max).desc)
             .filter(
                 ZcashTransaction.Overview.Column.minedHeight == nil &&
                 ZcashTransaction.Overview.Column.expiryHeight > upTo

docs/cbp_state_machine.puml

@@ -26,7 +26,13 @@ updateChainTip -[#green,bold]-> download : Processing of scan range continues
 
 processSuggestedScanRanges : ProcessSuggestedScanRangesAction
 processSuggestedScanRanges -[#green,bold]-> download : Scan range available to process
-processSuggestedScanRanges -[#green,bold]-> finished : Scan ranges FULLY processed
+processSuggestedScanRanges -[#green,bold]-> txResubmissionA : Scan ranges FULLY processed
+
+txResubmissionA : TxResubmissionAction
+txResubmissionA -[#green,bold]-> finished
+
+txResubmissionB : TxResubmissionAction
+txResubmissionB -[#green,bold]-> updateChainTip
 
 download : DownloadAction
 download -[#green,bold]-> scan
@@ -42,7 +48,7 @@ clearAlreadyScannedBlocks : ClearAlreadyScannedBlocksAction
 clearAlreadyScannedBlocks -[#green,bold]-> enhance
 
 enhance : EnhanceAction
-enhance -[#green,bold]-> updateChainTip : Range NOT finished
+enhance -[#green,bold]-> txResubmissionB : Range NOT finished
 enhance -[#green,bold]-> clearCache : Range finished, clear cache and check the scan ranges
 
 note right of enhance