Remove documents from store on collection deletion #LMR-793 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livthomas
reviewed
May 5, 2018
| const ids: string[] = state.ids as string[]; | ||
| const entities = state.entities; | ||
| return ids.map((id: string) => entities[id]) | ||
| .filter(document => document.collectionId === collectionId) |
There was a problem hiding this comment.
Why do we map ids to entities here? What about filtering just entities?
return Object.values(state.entities)
.filter(document => document.collectionId === collectionId)
.map(document => document.id);In the future, we will hopefully be able to remove entities by a predicate (see this NgRx issue).
There was a problem hiding this comment.
Oh I was looking for something like that, thanks!
livthomas
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.