[RM-1480] Suppress InvalidVpcID.NotFound on describe VPC classic link calls #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtis-fugue
requested review from
tyler-luminal,
grim-luminal,
mike-luminal and
eric-luminal
mike-luminal
approved these changes
Feb 21, 2019
|
Update: the VPC that triggers the issue is a shared VPC which does not support classic link. I've reproduced the error and confirmed this change fixes it. |
|
Raising a flag here that this may cause future conflicts with the Terraform provider. They added support for VPC Sharing in December (hashicorp#6642). It doesn't look like they've addressed the issue we're seeing. |
mike-luminal
pushed a commit
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some VPCs incorrectly fail to refresh due to
InvalidVpcID.NotFound.What
In some research I found a potential cause that cropped up for other people: describe VPC classic link calls can fail with this:
ansible/ansible#36083
This PR suppresses the error on
DescribeVpcClassicLinkandDescribeVpcClassicLinkDnsSupportwhich are made to set the optional attributesenable_classiclinkandenable_classiclink_dns_support.https://www.terraform.io/docs/providers/aws/r/vpc.html#enable_classiclink
The provider already suppresses
UnsupportedOperationfor both of these calls, but my suspicion is AWS may also return VPC not found in certain cases.