Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dune #55

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Update Dune #55

merged 1 commit into from
Jun 5, 2022
+3 −2

Conversation

liyishuai
Copy link
Collaborator

https://github.com/coq/ceps/blob/master/text/048-packaging-coq-native.md#note-to-library-developers-and-package-maintainers

  • for dune / coq.theory: this will require Coq 8.12.1+ and a version of dune implementing PR ocaml/dune#3210 (cf. this comment by @ejgallego); otherwise (without native support), Dune will just ignore the native parts and no ./coq-native/*.cmxs file will be installed.

@liyishuai
Update Dune

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
492ce54
@liyishuai liyishuai requested a review from Lysxia June 5, 2022 03:38
@liyishuai liyishuai mentioned this pull request Jun 5, 2022
Closed
@liyishuai
Copy link
Collaborator Author

Should we add dependent check as well?

@Lysxia
Copy link
Owner

Lysxia commented Jun 5, 2022

Should we add dependent check as well?

Feel free. But I would prefer whitelisting them instead of getting whatever is listed on opam.

@Lysxia Lysxia merged commit 8637917 into master Jun 5, 2022
@Lysxia Lysxia deleted the native branch June 5, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lysxia Lysxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liyishuai @Lysxia