-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for task arguments #43
base: master
Are you sure you want to change the base?
Conversation
Overall this looks good, but I found the following edge cases that would still need to work:
here is the setup I was using to test it
index.js function foo(arg) {
console.log(arguments);
}
foo(process.argv.slice(2)); foo.js function foo(arg) {
console.log(arguments);
}
foo(process.argv.slice(2).reverse()); |
We should add a test suite. |
That is something I would love to do, if you have an idea on how to implement, please open an issue/pr so we can discuss it in a dedicated location |
I'd like to do it here in a separate commit, as it'll help me be sure that my PR passes your above case. |
Generally I would prefer to separate something like that out to a dedicated PR, but as long as each commit is self contained, go ahead and do it on this PR |
…with a more reusable API that can facilitate tests.
…when task name is specified. It is not currently possible to support arguments without a task because argv[2] was hard-coded to be the task name. If it were defined as “--arg”, it would treat that as the task name. fixes M-Zuber#37
…by only exporting what is necessary for production use.
Travis and AV are both connected now |
This is waiting on #46
This change is