Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): do not block connection handler task during client auth #35

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

M0dEx
Copy link
Owner

@M0dEx M0dEx commented Jan 8, 2024

This PR fixes #34, where a malicious client could block the connection handler task by delaying client authentication.

@M0dEx M0dEx self-assigned this Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (13e7f48) 70.01% compared to head (95739bd) 71.40%.

Files Patch % Lines
src/server/connection.rs 59.37% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   70.01%   71.40%   +1.38%     
==========================================
  Files          19       19              
  Lines        1004     1014      +10     
==========================================
+ Hits          703      724      +21     
+ Misses        301      290      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M0dEx M0dEx merged commit 42f05c0 into main Jan 8, 2024
6 checks passed
@M0dEx M0dEx deleted the #34/client-auth-dos-fix branch January 8, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awaiting client authentication blocks the connection management task
1 participant