[BUG] Upgrading from 1.11.11 to 1.99.11 includes restricted permissions

[jesselai]

In the upgrade process from 1.11.11 to 1.99.11 there were some migration issues. On apps that have Location or System restricted, there are some of the red potentially dangerous items that were automatically checked after the upgrade that I don't think should be. I listed those below.

Location:

• getProviders
• isProviderEnabled

System:

• getPackagesHoldingPermissions
• queryIntentContentProviders

I reported in the forum, but mostly am creating this issue here so it doesn't get lost and also get a notification on update.

[jesselai]

Hi Marcel, I tried upgrading again from 1.11.11 to 1.99.14 and 1.99.16, and it still had the problem described in the original report.

Edit: Also, just checked the commit and noticed that it attempted to add a version check for the Location settings. Was there a different commit that was for the System ones?

[M66B]

Indeed, defining the version number from for the functions is not enough, the upgrade process should be run after the migrate to set it right.

This should be fixed in this version: http://d-h.st/nGX

I would be grateful if you test it and let me know if it is really fixed now.

[jesselai]

I just tested the version that you linked in an upgrade from 1.11.11. It worked flawlessly. I noticed that there is now an upgrading dialog which is a nice touch. Thanks for looking into it again. I checked several apps to ensure that it was correct. I also double check some apps that had Internet restricted before the upgrade, and those settings looked correct as well in terms of the new restrictions.

[M66B]

Thank your very much for testing and reporting back!