Issue with restrict whole category.

[Cyclu]

I have found that restrict the whole category not work on first attempt uncheck/check the whole category checkbox fix this behaviour this happens for the functions which I have unrestricted earlier as XPrivacy had it in mind/cache? or for the new restrictions. For example storage some time ago I have unrestricted certain functions then I have unrestricted the entire category next time when I wanted restrict the whole category the new function "open" was not restricted or "media" for which I have done before the function unrestricted.
To found what the problem which I cannot reproduce with the same application why I can to do next time when I found an other application with this behaviour because like I said above once set Uncheck/Check the entire category fix the problem.

[M66B]

This is insufficient: https://github.com/M66B/XPrivacy#FAQ52

• Which view? Application list or application details?
• Which category?
• Which steps should I follow to reproduce this?

I test a lot with XPrivacy and have never seen this problem.

[jpeg729]

Were you expecting it to restrict all the functions in the category right away?
Because individual function settings are only reset when clearing a category.

So, what might have happened is that the category was set to allow+ask, and at a prompt you chose to allow a function. That adds a setting for that function without touching the category. Then later you try to restrict the entire category in the ui, and it keeps the function allowed the first time round.

[Cyclu]

Sorry I will add now.
I precise this happens with disabled on-demand settings and also I recalled that it happened before this future was added.
View: Applications details
Category: Storage
Steps:
-1 go into app detailed view
drill down arrow for storage category
restrict the whole category
unchecked an function.
-2 return back to app detail view
unrestricted the whole category
-3 return back to app detail view
restrict the whole category
the function which I have unchecked at point 1 is not checked.
Also I precise that I have not touched these settings a certain time between each change and have done many Xprivacy update.

[M66B]

I have tried several times what you have described, but I cannot reproduce this.

[Cyclu]

it does not matter much it's just a minor inconvenience. I will reinstall soon my rom from scratch
since 9 months of continuous XPrivacy update I think it will settle certain behaviour.

[ghost]

I think that I am suffering from this bug. Thats assuming that I understood the description correctly.

Please see this video: https://docs.google.com/file/d/0B7IMZIRnHA0_b1JqVk9aeDVKTFU/edit?pli=1

This happens to several apps and categories. I have experienced this bug on multiple devices:

• Samsung Galaxy Note II, Omnirom, XPrivacy 2.0.xx. Updated from XPrivacy 1.yy.xx. I do not own the device anymore.
• Google Nexus 10, Cyanogenmod, XPrivacy 2.0.14. Updated from XPrivacy 1.yy.xx. Stopped using XPrivacy because of this bug.
• Google Nexus 5, Omnirom, XPrivacy 2.0.14. Updated from XPrivacy 2.00.xx. Still using XPrivacy.

[M66B]

The video shows the bug clearly, thanks.
However, I like to know more, since I am not able to reproduce this bug.
What did you do before the video?
Was this a blank, new install of XPrivacy?
Did you import settings?
Whatever else can be relevant.
I cannot fix this bug, if I cannot reproduce it.

[M66B]

A logcat capture during reproduction of this bug with XPrivacy debugging enabled (main settings) may also help.

[ghost]

What did you do before the video?

• Second video: https://docs.google.com/file/d/0B7IMZIRnHA0_UEZ5M3dSTGE2YVk/edit?pli=1.

Was this a blank, new install of XPrivacy?

• The video is from my Nexus 5. Started from a fresh XPrivacy 2.0.xx install and gradually updated to XPrivacy 2.0.14.

Did you import settings?

• No.

A logcat capture during reproduction of this bug with XPrivacy debugging enabled (main settings) may also help.

• I'll see what I can do.

[ghost]

I just send you a logcat through your website. This time I restricted an app called cerberus in the same manner as in earlier videos. Tell me if you require a full logcat without filtering (grep XPrivacy logcat.txt).

[ghost]

Whatever else can be relevant.

• I have never explicitly restricted the apps used as examples (App Settings, Google Authenticator, Cerberus). Or at least I'm pretty sure that I haven't. However, the bug happens to previously restricted apps as well.

[M66B]

I like to know if you collapse and expand the category if still everything isn't checked.

I see nothing obviously wrong in the code and since this is just reported twice and I cannot reproduce it, it might very well a bug in your ROM.

[M66B]

I also like to know if you close the application details view and return back if the settings are still wrong.

[ghost]

I like to know if you collapse and expand the category if still everything isn't checked.

• I tried a different app this time. Everything stays unchecked after collapse and expand.

I also like to know if you close the application details view and return back if the settings are still wrong.

• I tried a different app this time. Everything stays unchecked after pressing back button multiple times.

I seems that the bug occurs when a category is restricted for the first time. I checked the Identification category for App Settings app and it worked this time. Then I tried to restrict the Shell category and the bug occured again.

[an0n981]

I've also noticed this on different devices with different roms during initial XPrivacy setup. @gentoolkit if you filter the app detail view to the category and then check the apps you want to restrict, it should work propwrly

[ghost]

@an0n981 Do you mean like this: https://drive.google.com/file/d/0B7IMZIRnHA0_N3RQVkd1RmI0WFE/edit?usp=sharing

The bug still occurs.

[an0n981]

Yes I meant like that, that I have never seen happen

Regards,

an0n981

-------- Original Message --------
From: gentoolkit [email protected]
Sent: April 12, 2014 4:51:16 PM CEST
To: M66B/XPrivacy [email protected]
Cc: an0n981 [email protected]
Subject: Re: [XPrivacy] Issue with restrict whole category. (#1566)

@an0n981 Do you mean lite this: https://drive.google.com/file/d/0B7IMZIRnHA0_N3RQVkd1RmI0WFE/edit?usp=sharing

The bug still occurs.

---

Reply to this email directly or view it on GitHub:
#1566 (comment)

[M66B]

Can you please try if the issue is fixed in this version: http://d-h.st/o7B

[ghost]

Unfortunately it did not help.

[M66B]

I have no idea what is causing this, for me and as it seems for many others it just works.
It is difficult to fix something that cannot be reproduced.
I tried with some wild guesses, but I am out of ideas.
Hopefully somebody having this same issue with programming skills can pinpoint the problem.

[ghost]

I just cleared all XPrivacy data and the bug is gone. However, if I remember correctly, I have tried this before and the bug came back. I will report if it happens again.

[ghost]

Something interesting just happened. I had to factory reset my Nexus 5 from unrelated reasons. The first thing I did was to install XPosed, XPrivacy and a few other apps. Everything worked fine until I decided to install Titanium Backup and restored a few of the missing apps. As a result the bug started occuring again. Then I cleared all XPrivacy data and everything was OK again. I thought that this was a bit odd, so I decided to restore all the missing apps I could. And, as you can probably guess, the bug started occuring again. Clearing all XPrivacy data was once again the appropriate fix for the problem.

A some type of mismatch between Xprivacy and Titanium Backup could explain the problems I have been experiencing. However, I used Titanium Backup only a few times before this factory reset to restore apps. Maybe a single restore operation is enough to to mess up things...

[M66B]

This is not a bug.
You have on demand restricting enabled and probably the default template.
This means that all categories and functions will be set to not restricted when installing a new application (including through Titanium backup).
Restricting a category in this case will leave all functions of an category not restricted.
When unrestricting the category, all settings will be cleared, including all function exceptions.
So the next time you restrict the category, there are no function exception.
I have no clear idea about how to improve this.

[ghost]

Ok. Maybe you could make the category check box more clear. For example:
[red check mark] = Category fully restricted including all "dangerous functions"
[blue check mark] = Category fully restricted, no "dangerous functions" in the category
[red square] = Category partially restricted including some "dangerous functions"
[blue square] = Category fully restricted excluding "dangerous functions"
[gray? square] = Category partially restricted excluding "dangerous functions"

[ghost]

In addition, disabling the on demand restriction functionality from the application details window should probably restore the application details window into the normal operation mode. Maybe it should even reset everything so that the user does not get confused as I did.

[M66B]

Version 2.0.16 beta should fix this problem.
https://github.com/M66B/XPrivacy/releases/tag/2.0.16