Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

[Request] onDemand in App Overview #1615

Closed
an0n981 opened this issue Apr 2, 2014 · 29 comments
Closed

[Request] onDemand in App Overview #1615

an0n981 opened this issue Apr 2, 2014 · 29 comments

Comments

@an0n981
Copy link
Contributor

an0n981 commented Apr 2, 2014

Idea: when 'all' is selected, toggle 'Restrict onDeman', when a category is filtered toggle onDemand for that category

@banderos101
Copy link

+1

@Martinusbe
Copy link
Contributor

+1 Go for it

@an0n981
Copy link
Contributor Author

an0n981 commented Apr 3, 2014

From XDA thread:
@memethecat :
So does this
"when a category is filtered toggle onDemand for that category"
mean all other on-demand boxes in the given app will be empty?
I think that's what most people are looking for, empty boxes.

@an0n981
My idea was to have the onDemand ? in the app overview work the same way as the restriction check box

@M66B
Copy link
Owner

M66B commented Apr 3, 2014

Lets be clear: this issue is not about filtering.

@an0n981
Copy link
Contributor Author

an0n981 commented Apr 3, 2014

if that is how it sounded maybe I should have worded it better. I would like to be able to utilize (1) this area to check or uncheck onDemand, either completely for the app if All is seleceted (2) here, or for the selected category
screenshot_2014-04-03-08-25-46

@M66B
Copy link
Owner

M66B commented Apr 3, 2014

This is how I understood it :-)

@wbedard
Copy link

wbedard commented Apr 3, 2014

+1
While I'm pretty open to some of the implementation details, a feature along these lines would greatly assist those finally getting into Restrict-On-Demand.

@danielmmmm
Copy link
Contributor

What would speak against having the on-demand check boxes always displayed, like the restriction boxes? As far as I can see, this wouldn't even cost us any screen real-estate, because all categories and functions are two-liners anyways.
To make things more consistent and easier to understand for n00bs, the black/white question mark from the app list could also be shown to the right of the on-demand checkbox in the app view (with minimal margins to not lose any more space). The on-demand checkbox should then also become a tri-state box with a question mark, filled with a blue square and empty. The setting "Restrict on demand" could be removed from the settings dialog.

The original proposal by an0n981 sounds a bit complicated to me (no offense an0n981 ;-)

@hollal
Copy link

hollal commented Apr 3, 2014

+1

@Cyclu
Copy link

Cyclu commented Apr 3, 2014

Another +1
It still lacks four +1 Wake up the guys ;)

@danielmmmm
Copy link
Contributor

I didn't give a 1+ yet because it is still unclear to me how this feature would be implemented. Marcel seems to be reluctant to implement the original proposal. Any comments on my approach?

@Phylon
Copy link
Contributor

Phylon commented Apr 3, 2014

+1
Just my (one) cent...

@Firetribe
Copy link

+1

2 similar comments
@CedarI
Copy link

CedarI commented Apr 4, 2014

+1

@vibes340
Copy link

vibes340 commented Apr 4, 2014

+1

@zamzing
Copy link

zamzing commented Apr 5, 2014

Good idea... +1

@banderos101
Copy link

"I didn't give a 1+ yet because it is still unclear to me how this feature would be implemented. Marcel seems to be reluctant to implement the original proposal. Any comments on my approach?"

I think i jumped the shark myself, ideally, i would want the ability to toggle the ? in an apps main screen also, rather then fiddling about with an app, and then having to go go to main screen to toggle ? (Select/unselect), when i was just in that app, seems like an unecesary step, in this specific scenario, dont get me wrong, the original idea ks still usefull, and maybe its a completely different request then what i had originally thought, so my bad for imposing another request here if so

@M66B
Copy link
Owner

M66B commented Apr 5, 2014

I will add a column of check boxes, depending on a new setting. This will be the only visible changes.
The check boxes will toggle on demand for the selected category and will toggle on demand on/off when the all category is selected.

@banderos101
Copy link

That is most welcomed, hopefully in the very distant well rested plenty of time on your hands future, we might be able to bring it all the way down to the restriction aswell as category level, but that is another discussion for another time, for now, additional main console control is a most welcomed addition

@M66B M66B closed this as completed in 9ad3f7e Apr 8, 2014
M66B pushed a commit that referenced this issue Apr 8, 2014
M66B pushed a commit that referenced this issue Apr 8, 2014
M66B pushed a commit that referenced this issue Apr 8, 2014
@M66B
Copy link
Owner

M66B commented Apr 8, 2014

In the All view you can enable/disable the on demand restricting switch for applications.
In a category view you can enable/disable on demand restricting for the selected category.
To enable/disable on demand restricting for a category, you need to enable the switch first.
The half state should display correctly in all cases.
Globally disabling on demand restricting will hide the new check boxes column.

@an0n981
Copy link
Contributor Author

an0n981 commented Apr 8, 2014

👍

@an0n981
Copy link
Contributor Author

an0n981 commented Apr 8, 2014

When all onDemand ? have been removed for an app, shouldn't the half state be empty?

@M66B
Copy link
Owner

M66B commented Apr 8, 2014

No, because in the All view the check box should reflect the on demand switch state. The half state is just an extra. What I will change is that the half state will be shown if on demand restricting for all categories is turned off.

@M66B
Copy link
Owner

M66B commented Apr 8, 2014

New test version: http://d-h.st/6QI

Please test this new feature thoroughly and report your findings in this issue.

@an0n981
Copy link
Contributor Author

an0n981 commented Apr 8, 2014

Tested thoroughly 👍

@M66B
Copy link
Owner

M66B commented Apr 8, 2014

What still is missing is a setting to enable this feature, maybe I will tie it to 'restrict dangerous'.

@M66B
Copy link
Owner

M66B commented Apr 8, 2014

This feature is in beta version 2.0.15.
https://github.com/M66B/XPrivacy/releases/tag/2.0.15

You need to enable 'restrict dangerous' to use this feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

14 participants