Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Possible issues when fetching accounts restrictions #986

Closed
an0n981 opened this issue Dec 19, 2013 · 6 comments
Closed

Possible issues when fetching accounts restrictions #986

an0n981 opened this issue Dec 19, 2013 · 6 comments

Comments

@an0n981
Copy link
Contributor

an0n981 commented Dec 19, 2013

Submiting account restrictions that are set to deny with only one account allowed could cause the voting system to set accounts restrictions to deny for users fetching these settings, which would make certain apps inoperable (WhatsApp for example) as acvounts need to be unrestricted to setuo the account.
Suggestion: Either mark such submitions as if accounts were not restricted or don't accept these submitions

@kaizokan
Copy link

I would not go with marking such submitions as if accounts were not restricted. because then all accounts will be unprotected after fetching. i think it's better to have them at default restricted and if necessary manually allowed.
maybe adding a popup after fetch for these kind of restrictions in which you tel them to allow specific accounts yourself. to know which sumbits have allowed account a true or false code could be exported inside backup to at least know that one or more accounts are supposed to be allowed.

@jpeg729
Copy link
Contributor

jpeg729 commented Dec 20, 2013

A nice touch would be to save the account type (Google, Facebook, Whatsapp,
...) and prompt for which to allow, or at least mark the app as needing
specific attention.

On 20 December 2013 00:34, kaizokan [email protected] wrote:

I would not go with marking such submitions as if accounts were not
restricted. because then all accounts will be unprotected after fetching. i
think it's better to have them at default restricted and if necessary
manually allowed.
maybe adding a popup after fetch for these kind of restrictions in which
you tel them to allow specific accounts yourself. to know which sumbits
have allowed account a true or false code could be exported inside backup
to at least know that one or more accounts are supposed to be allowed.


Reply to this email directly or view it on GitHubhttps://github.com//issues/986#issuecomment-30977161
.

@jpeg729
Copy link
Contributor

jpeg729 commented Dec 20, 2013

Contacts and application restrictions could pose a problem too.

@M66B
Copy link
Owner

M66B commented Dec 20, 2013

I will work on this this weekend.
Submit and fetch will be extended with a flag indicating accounts, applications or contact were selected.

@jpeg729
Copy link
Contributor

jpeg729 commented Dec 20, 2013

I can work on finding the account type(s) to save, and implementing some sort of indicator, if you like.

@M66B
Copy link
Owner

M66B commented Dec 21, 2013

The next version of XPrivacy will submit if there were accounts, applications and/or contacts allowed. The crowd sourced restriction server has already been adapted to store and use this info, so even older versions of XPrivacy will get the correct restrictions. If anything is allowed the corresponding category will not be restricted to prevent problems. The function exceptions are fetched, so it is easy to allow an account and restrict the category with the correct exceptions.

The crowd sourced restrictions web site has also been adapted to show the new information (column exceptions)

@M66B M66B closed this as completed Dec 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants