Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Fixed RTL-languages translations (-ar/-fa/-he/-ku) #1446

Merged
merged 6 commits into from
Mar 7, 2014
Merged

Conversation

Phylon
Copy link
Contributor

@Phylon Phylon commented Feb 24, 2014

Problems with displaying right-to-left scripted languages have been fixed.
(word order and dislocated /reversed brackets patched). Such problems
occur mainly in strings with formatting parameters or strings with mixed
elements from both rtl- and ltr-languages. Changes have been tested with XPv1.99.53 / JB4.1.2.

Phylon and others added 2 commits February 24, 2014 12:58
Problems with display right-to-left scripted languages have been fixed.
(word order and dislocated /reversed brackets fixed). Such problems
occur mainly in strings with formatting parameters or strings with mixed
elements from both rtl- and ltr languages.
@M66B M66B added the pull label Feb 25, 2014
Phylon pushed a commit to Phylon/XPrivacy that referenced this pull request Feb 26, 2014
Fixed RTL-languages translations (-ar/-fa/-he/-ku)
@M66B M66B closed this Mar 6, 2014
@Phylon
Copy link
Contributor Author

Phylon commented Mar 6, 2014

The display errors are independent of the format string. Shall I remove the positional formats and provide the fixed files for these "special" languages?

@M66B
Copy link
Owner

M66B commented Mar 6, 2014

I like to have the translators do this, since you and I cannot check if everything is correct, especially not for non latin scripts. Maybe you can make a script for this too, so that a translator can run this on the next update.

@Phylon
Copy link
Contributor Author

Phylon commented Mar 6, 2014

Unfortunately, a script does not make sense because the changes I made were not the same for the different languages. I made all changes manually and tested the changes on my phone until everything looked allright. I only corrected problems that affected the "About" window.

@M66B M66B reopened this Mar 6, 2014
@Phylon
Copy link
Contributor Author

Phylon commented Mar 6, 2014

Positional format reverted, cleanup done (see comment in issue #1344), everything should be ready for take-off.

@M66B
Copy link
Owner

M66B commented Mar 7, 2014

I am not going to merge this, because I am still afraid things will break.
This is up to the translators to fix.

@M66B M66B closed this Mar 7, 2014
@Phylon
Copy link
Contributor Author

Phylon commented Mar 7, 2014

What do you mean by "This is not correct, Arabic script is written from right to left."??
This fix was all about languages which are written right to left!?

@Phylon
Copy link
Contributor Author

Phylon commented Mar 7, 2014

As a reference and for documentation purposes, I have attached screenshots of the broken arabic language file currently used in XPrivacy and the fixed version I have created.

I know you don't want to use it, but let me know what exactly is incorrect and how you discovered the error, because I put quite some effort into creating and testing this fix. So I would like to learn what I did wrong and why I missed it.

screenshot_ar_broken_2014-03-07-12-36-21
screenshot_ar_fixed_2014-03-07-12-22-21

@M66B
Copy link
Owner

M66B commented Mar 7, 2014

I am going to trust you did this well.
If you update the pull request, so I can merge it without conflicts, I will merge it.

@M66B M66B reopened this Mar 7, 2014
@Phylon
Copy link
Contributor Author

Phylon commented Mar 7, 2014

Latest versions have been checked again with 1.99.71. Merge conflicts have been resolved.

M66B added a commit that referenced this pull request Mar 7, 2014
Fixed RTL-languages translations (-ar/-fa/-he/-ku)
@M66B M66B merged commit cbe3c54 into M66B:master Mar 7, 2014
@M66B
Copy link
Owner

M66B commented Mar 7, 2014

Thanks for your patience with stubborn me ;-)

@Phylon
Copy link
Contributor Author

Phylon commented Mar 7, 2014

You are always welcome! I am sometimes stubborn as well...

@Phylon Phylon deleted the patch-1 branch March 7, 2014 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants