-
Notifications
You must be signed in to change notification settings - Fork 527
Fixed RTL-languages translations (-ar/-fa/-he/-ku) #1446
Conversation
Problems with display right-to-left scripted languages have been fixed. (word order and dislocated /reversed brackets fixed). Such problems occur mainly in strings with formatting parameters or strings with mixed elements from both rtl- and ltr languages.
The display errors are independent of the format string. Shall I remove the positional formats and provide the fixed files for these "special" languages? |
I like to have the translators do this, since you and I cannot check if everything is correct, especially not for non latin scripts. Maybe you can make a script for this too, so that a translator can run this on the next update. |
Unfortunately, a script does not make sense because the changes I made were not the same for the different languages. I made all changes manually and tested the changes on my phone until everything looked allright. I only corrected problems that affected the "About" window. |
Positional formats have been removed from all language translation strings files.
Positional format reverted, cleanup done (see comment in issue #1344), everything should be ready for take-off. |
I am not going to merge this, because I am still afraid things will break. |
What do you mean by "This is not correct, Arabic script is written from right to left."?? |
As a reference and for documentation purposes, I have attached screenshots of the broken arabic language file currently used in XPrivacy and the fixed version I have created. I know you don't want to use it, but let me know what exactly is incorrect and how you discovered the error, because I put quite some effort into creating and testing this fix. So I would like to learn what I did wrong and why I missed it. |
I am going to trust you did this well. |
Latest versions have been checked again with 1.99.71. Merge conflicts have been resolved. |
Fixed RTL-languages translations (-ar/-fa/-he/-ku)
Thanks for your patience with stubborn me ;-) |
You are always welcome! I am sometimes stubborn as well... |
Problems with displaying right-to-left scripted languages have been fixed.
(word order and dislocated /reversed brackets patched). Such problems
occur mainly in strings with formatting parameters or strings with mixed
elements from both rtl- and ltr-languages. Changes have been tested with XPv1.99.53 / JB4.1.2.