Bump C++ requirement to C++17 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomodachi94
force-pushed
the
bump-cpp-requirement
branch
2 times, most recently
from
434e8fb to
0562f71
Compare
The 1.13.0 release of Poco requires a newer version of C++, specifically C++17. The configuration phase will fail to find the Poco headers with an older C++ version. Changes to ./configure may be reproduced by running autoconf v2.72. Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26 Relevant discussion: NixOS/nixpkgs#283809 (comment)
tomodachi94
force-pushed
the
bump-cpp-requirement
branch
from
0562f71 to
f2164bc
Compare
|
CI failed before this PR with the same error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1.13.0 release of Poco requires a newer version of C++, specifically C++17. The configuration phase will fail to find the Poco headers with an older C++ version.
Changes to
./configuremay be reproduced by running autoconf v2.72.Changelog: https://raw.githubusercontent.com/pocoproject/poco/poco-1.13.0-release/CHANGELOG
Nixpkgs patch: https://github.com/NixOS/nixpkgs/blob/6dd5612cdd562163dc7a7341e3be9c3f6f4d9078/pkgs/tools/graphics/sanjuuni/default.nix#L22-L26
Relevant discussion: NixOS/nixpkgs#283809 (comment)