Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for OCC sound-keys include dependency #7

Open
mitchts opened this issue Jan 6, 2025 · 0 comments
Open

Check for OCC sound-keys include dependency #7

mitchts opened this issue Jan 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@mitchts
Copy link
Member

mitchts commented Jan 6, 2025 •
edited
Loading

Overcast Community sound-keys include is part of the global include scope and not per map. We need to, on a best-effort, determine if a map is actually using this include when defining sound actions so that the sound-keys include can be listed as a dependency for the map.

https://github.com/OvercastCommunity/PublicMaps/blob/main/includes/sound-keys.xml

https://github.com/OvercastCommunity/PublicMaps/blob/main/includes/global.xml
@mitchts mitchts added the enhancement New feature or request label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitchts