changed encore test to be xfail for now #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2159 +/- ##
========================================
Coverage 89.44% 89.44%
========================================
Files 157 157
Lines 18775 18775
Branches 2713 2713
========================================
Hits 16794 16794
Misses 1378 1378
Partials 603 603Continue to review full report at Codecov.
|
|
@orbeckst this is just failing because of the gsd + windows thing I fixed elsewhere |
|
Can you merge the other thing and make it pass?
…--
Oliver Beckstein
email: [email protected]
Am Dec 5, 2018 um 08:35 schrieb Richard Gowers ***@***.***>:
@orbeckst this is just failing because of the gsd + windows thing I fixed elsewhere
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
richardjgowers
force-pushed
the
issue-2158-encore_failing
branch
from
226dbdf to
ec90f28
Compare
can fail if it likes without slowing down development
tylerjereddy
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
This is probably fine as a band aid fix as long as the cognate issues remain open.
The reasons for the xfails could be moved to within its argument (instead of as separate comments) so test runs report back more clearly, but probably not worth worrying about.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
band aid for #2158 so we can still get PRs done in the meantime...