Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks default python in asv.conf.json #4352

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

hmacdope
Copy link
Member

@hmacdope hmacdope commented Dec 5, 2023

Fixes #4351

Changes made in this Pull Request:

  • changes default python version in benchmarks to be 3.10

PR Checklist

  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4352.org.readthedocs.build/en/4352/

@hmacdope hmacdope changed the title Update asv.conf.json Update benchmarks default python in asv.conf.json Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Linter Bot Results:

Hi @hmacdope! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🚢 it!

@orbeckst
Copy link
Member

orbeckst commented Dec 5, 2023

@hmacdope please feel free to merge once CI is happy.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a474dd3) 93.37% compared to head (3ea1357) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4352     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22340    23453   +1113     
  Branches      4085     4085             
==========================================
+ Hits         20859    21899   +1040     
- Misses         963     1036     +73     
  Partials       518      518             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmacdope hmacdope merged commit 37d8fee into develop Dec 5, 2023
24 of 25 checks passed
@RMeli RMeli deleted the change_bench_default_py branch December 23, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change benchmarks default python to be >3.8
2 participants