Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Codecov action to v5 #4887

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Update Codecov action to v5 #4887

merged 1 commit into from
Feb 2, 2025

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Jan 8, 2025

Update codecov action from v4 to v5 (changes deprecated variables to new values).

I suspect that the fix for #4576 would be to switch to token-less access, but I need to understand this better.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4887.org.readthedocs.build/en/4887/

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (d222720) to head (169f2b2).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4887      +/-   ##
===========================================
- Coverage    93.65%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21795    22861    +1066     
  Branches      3067     3067              
===========================================
+ Hits         20413    21406     +993     
- Misses         931     1004      +73     
  Partials       451      451              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RMeli RMeli closed this Jan 26, 2025
@RMeli RMeli reopened this Jan 26, 2025
@RMeli
Copy link
Member Author

RMeli commented Jan 26, 2025

Cycled PR after allowing tokenless uploads.

@RMeli
Copy link
Member Author

RMeli commented Feb 2, 2025

Not 100% sure this improves things (the codecov/project test is still failing), but I think it doesn't hurt either to update to the latest codecov action.

@RMeli RMeli marked this pull request as ready for review February 2, 2025 13:39
@IAlibay
Copy link
Member

IAlibay commented Feb 2, 2025

Not 100% sure this improves things (the codecov/project test is still failing), but I think it doesn't hurt either to update to the latest codecov action.

So my take, and I admit I don't know 100%, but I believe the codecov/project failure makes sense. Your branch is a commit behind HEAD, so there's a difference in coverage between the two.

@IAlibay IAlibay merged commit 1d2376e into MDAnalysis:develop Feb 2, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants