[refactor] make _remove_self_edges be skipped when doing matscipy graph build #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutackPark
changed the title
|
matscipy의 경우엔 필요없다는 걸 알았으니까 |
|
그게 더 깔끔해보이네요! 수정해서 올리겠습니다 |
hexagonrose
force-pushed
the
matscicheck
branch
from
6620a2c to
d824ddc
Compare
hexagonrose
force-pushed
the
matscicheck
branch
from
042a768 to
2fe92c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed _remove_self_edges function itself to be skipped when we use matscipy for graph build.