Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optimal number of components of all criteria accessible #48

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

eurunuela
Copy link
Collaborator

Closes none.

This PR makes the optimal number of components calculated with AIC, KIC, and MDL accessible with the class regardless of the user-selected criterion.

@eurunuela
Copy link
Collaborator Author

The first commit is actually from #47.

@eurunuela eurunuela requested a review from tsalo February 8, 2022 18:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #48 (3a8e1d1) into main (0ae41bb) will decrease coverage by 0.42%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   90.42%   90.00%   -0.43%     
==========================================
  Files           3        3              
  Lines         282      290       +8     
==========================================
+ Hits          255      261       +6     
- Misses         27       29       +2     
Impacted Files Coverage Δ
mapca/mapca.py 86.28% <81.25%> (-0.55%) ⬇️
mapca/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae41bb...3a8e1d1. Read the comment docs.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this as-is, but what about adding trailing underscores in the attribute names, per our sklearn-based convention?

@eurunuela
Copy link
Collaborator Author

Happy to merge this as-is, but what about adding trailing underscores in the attribute names, per our sklearn-based convention?

Agh, I keep forgetting that. Will do tomorrow, thank you Taylor!

@eurunuela
Copy link
Collaborator Author

Added trailing underscores. Merging assuming you're happy with the changes now.

@eurunuela eurunuela merged commit e379c26 into ME-ICA:main Feb 9, 2022
@eurunuela eurunuela deleted the enh/ncomps branch February 9, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants