w_div_w_crit_roche update #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orlox could you give this one a quick review and merge when you're ready? |
|
I like this fix, we should merge it as soon as we can. @matthiasfabry do you think it's ready to merge? Perhaps @pmocz or I can try to review it. It just needs a changelog entry. |
added 2 commits
January 30, 2025 14:57
# Conflicts: # star/defaults/controls.defaults # star/private/hydro_eqns.f90 # star/private/hydro_rotation.f90
|
I merged main and added a changelog entry, so if it looks good to all of you, we can merge this! |
|
Awesome, Fire away! |
warrickball
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with very short period binaries using the single rotating star fp/ft corrections, I noticed the that the sigmoid function that is used to smooth very large
j_rotwas interpreted incorrectly. I fixed this in the documentation.I also cleaned up some obsolete
ctrls, and took the liberty of updating the polynomial fits to the more accurate ones of Fabry+2022.