add etcd compact #18
Merged
add etcd compact #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadoci
reviewed
May 6, 2022
metadium/admin.go
Outdated
| log.Error("Metadium - failed to log the latest block", | ||
| "height", height, "hash", hash, "took", time.Since(tstart)) | ||
| } else { | ||
| log.Info("Metadium - logged the latest block", | ||
| "height", height, "hash", hash, "took", time.Since(tstart)) | ||
|
|
||
| if (rev%etcdCompactFrequency == 0) && (rev > 100) { |
There was a problem hiding this comment.
Shouldn't "100" be replaced by etcdCompactFrequency? I.e.
if rev%etcdCompactFreqency == 0 && rev > etcdCompactFreqency {
There was a problem hiding this comment.
Thanks! I added distinct var, named etcdCompactWindow, for more generalization and flexibility.
etcdCompactWindow is set to 100 as default.
There was a problem hiding this comment.
And, I updated codes to apply concept of compact window. Please check the following commits: 73062f1
* apply concept of compact window * update check logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcdPutspec: now return revision infoetcdCompactafteretcdPut(at everyrev%100==0)etcdCompactFrequencyis 100 as default