Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9853f23 erroneously moved the import of
FileObject
inpymisp/tools/create_misp_object.py
to theTYPE_CHECKING
conditional. This was later changed by 8fb34a2, however, the commit moved the import inside the try-except-block related tolief
. As a consequenceFileObject
is not imported iflief
is not available, but it is needed regardless, resulting in confusing exceptions unrelated tolief
:This pull request moves the import of
FileObject
outside the try-except block where it was before 9853f23.