Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn minimum number of processes #111

Merged
merged 2 commits into from
Mar 22, 2024
Merged

spawn minimum number of processes #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d72d827
spawn min num of processes
gtrevisan Mar 22, 2024
0d9a0af
leave logic of num procs to get_shots_data
gtrevisan Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion disruption_py/handlers/cmod_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ def get_shots_data(

shot_ids_request_params = ShotIdsRequestParams(self.database, Tokamak.CMOD, self.logger)
shot_ids_list = without_duplicates(shot_ids_request_runner(shot_ids_request, shot_ids_request_params))


# do not spawn unnecessary processes
num_processes = min(num_processes, len(shot_ids_list))

print(f"Retrieving data for {len(shot_ids_list)} shots from MDSPlus")

if num_processes > 1:
Expand Down
2 changes: 1 addition & 1 deletion test/test_cmod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def mdsplus_data(cmod_handler : CModHandler, shotlist) -> Dict:
shot_ids_request=shotlist,
shot_settings=shot_settings,
output_type_request="dict",
num_processes=min(MAX_PROCS, len(shotlist)),
num_processes=MAX_PROCS,
)
return shot_data

Expand Down