-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jlorincz/common testing #119
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
in order to help us develop the parameter methods, we should use the |
This comment was marked as outdated.
This comment was marked as outdated.
…ion-py into jlorincz/common_testing
This comment was marked as outdated.
This comment was marked as outdated.
…ion-py into jlorincz/common_testing
thank you! are you able to push the appropriate known failures list for each machine so that the tests pass? also, there might be some tweaks to be done on my earlier tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) as a final touch for now, please organize data in a more structured way, eg:
TEST_SHOTS = {
"CMOD": <current CMOD_TEST_SHOTS>,
"D3D: <current D3D_TEST_SHOTS>,
}
etc, it should be a lot easier to then read them up depending on the tokamak parameter.
(2) then, please remove the shot-by-shot info from the expected failures.
(3) finally, please fix the _fast
logic which is currently flipped.
TODO: