-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports #156
Fix imports #156
Conversation
(1) disruption-py/disruption_py/shots/parameter_methods/cmod/basic_parameter_methods.py Line 12 in 3f7cb19
vs DIII-D: disruption-py/disruption_py/shots/parameter_methods/d3d/basic_parameter_methods.py Lines 8 to 13 in 3f7cb19
(2) disruption-py/disruption_py/shots/parameter_methods/d3d/basic_parameter_methods.py Line 856 in 3f7cb19
or disruption-py/disruption_py/shots/parameter_methods/cmod/basic_parameter_methods.py Line 347 in 3f7cb19
? |
It is exclusively for older versions of MDSPlus that use a different error type, pre-2017, I believe (these are on iris). Hence, given our previous discussions, I will remove the try-catch. Additionally, the method used to catch the error in CMod is correct. Thanks for the pointers. |
at this point what about just changing:
to:
in order to directly use it? |
I looked at doing that, but they use quite a few other error types from mdsException in the cmod basic request file. I think that a future PR should be changing to the more specific error types. |
apply fixes for:
test with: