Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jlorincz/testing clarity #171

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Jlorincz/testing clarity #171

merged 1 commit into from
Jun 11, 2024

Conversation

lajz
Copy link
Collaborator

@lajz lajz commented Jun 11, 2024

Improved clarity of testing with python

@lajz lajz changed the base branch from main to dev June 11, 2024 00:43
gtrevisan
gtrevisan approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@gtrevisan gtrevisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests pass and behaves as expected, I trust it make sense as I've not looked into that class. 😄

@gtrevisan gtrevisan merged commit dcbc884 into dev Jun 11, 2024
7 checks passed
@gtrevisan gtrevisan deleted the jlorincz/testing_clarity branch June 11, 2024 20:11
@gtrevisan gtrevisan mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrevisan gtrevisan gtrevisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lajz @gtrevisan