Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFIT source tree in prad peaking computation #200

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

yumouwei
Copy link
Collaborator

@yumouwei yumouwei commented Jul 2, 2024

No description provided.

@yumouwei
Copy link
Collaborator Author

yumouwei commented Jul 2, 2024

@gtrevisan I don't understand why r0 & z0's tree_name were set to 'cmod'. From my understanding 'cmod' is the overarching tree & it's effectively setting them to 'analysis'. Changing them to '_efit_tree' appear to resolve the bug raised by Henry (#192).

@yumouwei yumouwei requested a review from gtrevisan July 2, 2024 15:18
@gtrevisan gtrevisan marked this pull request as ready for review July 2, 2024 17:55
@gtrevisan gtrevisan force-pushed the wei/debug-prad-peaking branch from 6c1e20e to 439d4f0 Compare July 2, 2024 17:56
@gtrevisan gtrevisan mentioned this pull request Jul 2, 2024
@gtrevisan gtrevisan changed the title Debug prad peaking Fix EFIT source tree in prad peaking computation Jul 2, 2024
@gtrevisan gtrevisan merged commit 97c6031 into dev Jul 2, 2024
6 checks passed
@gtrevisan gtrevisan deleted the wei/debug-prad-peaking branch July 2, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants