Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial framework support for EAST #386

Merged
merged 14 commits into from
Jan 22, 2025
Merged

Add initial framework support for EAST #386

merged 14 commits into from
Jan 22, 2025

Conversation

gtrevisan
Copy link
Member

  • allow different DB dialect,
  • allow fuzzy driver specification,
  • add version getter for DB,
  • add EAST minimal config for MDSplus and SQL.

@gtrevisan gtrevisan added the machine: EAST Related to the EAST tokamak label Jan 21, 2025
@gtrevisan gtrevisan requested a review from amdecker January 21, 2025 15:18
@@ -2,7 +2,7 @@
mdsplus_connection_string = "alcdata-archives"

[cmod.inout.sql]
driver = "ODBC Driver 18 for SQL Server"
driver = "ODBC"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have the exact driver is there a reason we should use the short name & rely on 'fuzzy' resolution?

Copy link
Member Author

@gtrevisan gtrevisan Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw differences between the different machines wrt the version number, so it seemed to me this was the easiest check of what driver one wants to use.
in any case, it should be clear enough that it could be adapted at will when the circumstances change.

to some extent, I currently see MFE WSs using ODBC, omega using FreeTDS, and EAST machines using MySQL, so the machines seem to have zero overlap.
also, I had SSL issues trying to use my ODBC connector with D3DRDB.

@gtrevisan gtrevisan merged commit 9bb8e3a into dev Jan 22, 2025
10 checks passed
@gtrevisan gtrevisan deleted the east branch January 22, 2025 18:40
@gtrevisan gtrevisan mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
machine: EAST Related to the EAST tokamak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants