Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Modal directive for admin application #11

Closed
MKHenson opened this issue Apr 16, 2016 · 0 comments
Closed

Create Modal directive for admin application #11

MKHenson opened this issue Apr 16, 2016 · 0 comments
Assignees
@MKHenson
Labels
enhancement

Comments

@MKHenson
Copy link
Owner

MKHenson commented Apr 16, 2016 •
edited
Loading

There is a lot of code reuse with the modal HTML and its code. This should be broken up into a directive. Specifically this should be for the error popup in the admin application. The code is pretty much copy and pasted in each state where its being used. This could possibly be extended further into a modal directive and sub classes in error modal and media modal.
@MKHenson MKHenson self-assigned this Apr 16, 2016
@MKHenson MKHenson changed the title Create Modal directive for admin Create Modal directive for admin application Jun 8, 2016
MKHenson added a commit that referenced this issue Jun 8, 2016
@MKHenson
Completed work on error modal drective. Closes issue #11
851832a
@MKHenson MKHenson closed this as completed Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MKHenson MKHenson

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MKHenson