Skip to content

Commit

Permalink
Update dependency stylelint-config-spaceninja to v15 [skip netlify] (#…
Browse files Browse the repository at this point in the history
…1131)

* Update dependency stylelint-config-spaceninja to v15 [skip netlify]

* bump stylelint, remove stylelint-config-prettier

* switch from yarn to npm to resolve some CLI issues that were specific to yarn.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Scott Vandehey <[email protected]>
  • Loading branch information
renovate[bot] and spaceninja authored Jan 4, 2024
1 parent 3990fc0 commit 4e363bd
Show file tree
Hide file tree
Showing 7 changed files with 16,758 additions and 10,231 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
cache: 'yarn'
cache: 'npm'
- name: Install Dependencies
run: yarn --frozen-lockfile
run: npm ci
- name: Run Lint
run: yarn lint:check
run: npm run lint:check

build:
runs-on: ubuntu-latest
Expand All @@ -33,8 +33,8 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
cache: 'yarn'
cache: 'npm'
- name: Install Dependencies
run: yarn --frozen-lockfile
run: npm ci
- name: Run Build
run: yarn build
run: npm run build
2 changes: 1 addition & 1 deletion .stylelintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
extends: ['stylelint-config-spaceninja', 'stylelint-config-prettier'],
extends: ['stylelint-config-spaceninja'],
rules: {
// disabling due to many false positives
'no-descending-specificity': null,
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ So you want to contribute to MLTSHP… Congratulations! Here's what you'll need
We use the "[fork and pull](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/getting-started/about-collaborative-development-models)" model, which means you'll need to start by [forking our repo](https://docs.github.com/en/get-started/quickstart/fork-a-repo#forking-a-repository), then make some changes, and then [submit a pull request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork) back to the main repo.

1. Fork [this repo](https://github.com/MLTSHP/mltshp-patterns/).
1. Run `yarn` to install dependencies.
1. Run `yarn storybook` to start a local instance of Storybook, our preview site.
1. Run `npm ci` to install dependencies.
1. Run `npm run storybook` to start a local instance of Storybook, our preview site.

Any changes you make should automatically be reflected in the preview site.

Expand Down Expand Up @@ -51,14 +51,14 @@ Only admins need to worry about these step.
1. `git checkout main`
1. `git pull`
1. Make sure you have a clean working tree (`git status` should show no changes)
1. `yarn install --frozen-lockfile`
1. `yarn lint:check`
1. `npm ci`
1. `npm run lint:check`
1. `npm version`
1. `npm publish` - This will automatically install and compile everything, run linting, and publish
1. `git push && git push --tags`

### to MLTSHP.com

1. `yarn build`
1. `npm run build`
1. Copy the minified CSS files from the `dist` folder to the `static/css` folder in the MLTSHP repo.
1. Open a new PR for the updated CSS files.
4 changes: 2 additions & 2 deletions netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
publish = "storybook-static"

# Default Storybook static build command
command = "yarn build-storybook"
command = "npm run build-storybook"

# Without this, Storybook's necessary devDependencies may not install. We
# could move those to full dependencies, but most of those dependencies are
# not necessary for projects consuming this library, so that would be silly.
NODE_ENV = "development"

Loading

0 comments on commit 4e363bd

Please sign in to comment.