Dev

mobros/commands/ros_install_runtime_deps/install_deps_executer.py

@@ -15,6 +15,7 @@
 from mobros.types.mobros_global_data import GlobalData
 from mobros.types.apt_cache_singleton import AptCache
 from mobros.exceptions import AptCacheInitializationException
+from mobros.constants import  Commands
 
 def check_if_requested_packages_are_in_desired_state(install_pkgs):
     """ Quick check if the requested packages are already in the desired state
@@ -296,7 +297,8 @@ def execute(self, args):
             sys.exit(1)
 
         install_pkgs = args.pkg_list
-        del install_pkgs[0]
+        if Commands.INSTALL.value in install_pkgs:
+            install_pkgs.remove(Commands.INSTALL.value)
 
         if not install_pkgs:
             logging.userInfo("No packages mentioned. Nothing todo.")

mobros/constants.py

@@ -1,5 +1,6 @@
 """Module to place all the package constants used throughout the package"""
 from os import environ
+from enum import Enum
 from mobros import __version__
 MOBROS_VERSION = __version__.version
 
@@ -45,3 +46,13 @@
     "version_gt": ">",
     "any": "any",
 }
+
+class Commands(Enum):
+    """Commands enumerate"""
+    INSTALL = "install"
+    INSTALL_BUILD_DEPS = "install-build-dependencies"
+    BUILD = "build"
+    PACK = "pack"
+    PUBLISH = "publish"
+    RAISE = "raise"
+    PING = "ping"

mobros/handler.py

@@ -14,16 +14,16 @@
 from mobros.commands.ros_pack.pack_executer import RosPackExecuter
 from mobros.commands.ros_raise.raise_executer import RosRaiseExecuter
 from mobros.commands.ros_rosdep_publish.rosdep_pub_executer import RosdepPublishExecuter
-from mobros.constants import MOBROS_VERSION
+from mobros.constants import MOBROS_VERSION, Commands
 
 executors = {
-    "install-build-dependencies": InstallBuildDependsExecuter,
-    "build": RosBuildExecuter,
-    "pack": RosPackExecuter,
-    "install": InstallRuntimeDependsExecuter,
-    "publish": RosdepPublishExecuter,
-    "raise": RosRaiseExecuter,
-    "ping": PingExecuter,
+    Commands.INSTALL_BUILD_DEPS.value: InstallBuildDependsExecuter,
+    Commands.BUILD.value: RosBuildExecuter,
+    Commands.PACK.value: RosPackExecuter,
+    Commands.INSTALL.value: InstallRuntimeDependsExecuter,
+    Commands.PUBLISH.value: RosdepPublishExecuter,
+    Commands.RAISE.value: RosRaiseExecuter,
+    Commands.PING.value: PingExecuter,
 }
 
 def handle():
@@ -49,7 +49,7 @@ def handle():
 
     command = ns.command
 
-    if command != "ping":
+    if command != Commands.PING.value:
         logging.userInfo("Mobros version: "+MOBROS_VERSION)
 
     h = ns.h