Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random_messages: implement Russian localisation #1050

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

Vagankovo
Copy link
Contributor

I'm only going to mark it ready for review until after I ask fellow Russian speakers of their opinion to work out some quirks and problems.

Copy link
Contributor

@Lucyucy Lucyucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 27-30 will not get translated. These messages should not be seperated but instead put into one string - see #1051

Copy link
Contributor

@Lucyucy Lucyucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, technically it should work but somehow line 27 (the "Use /top 50..." message) does not get translated. Neither in my translation nor in yours. I did not find the typo yet.
Also you forgot to add the message "To check all team members use /team." (line 30 in #1051)

Edit: line 27 does get translated, must've been a mistake on my side. So now there's just one message missing.

@LoneWolfHT
Copy link
Member

Let me know when you add the missing message. Or if you've lost interest I'll just merge this

@LoneWolfHT
Copy link
Member

Merging in ~12 hours

@LoneWolfHT LoneWolfHT merged commit a0f96e0 into MT-CTF:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants