Poisonous grenade

[farooqkz]

This PR adds poisonous grenade to the game which poison enemy team members when inside or very close to the smoke.

The poison will never damage the thrower or thrower team. It won't damage the thrower even if they change team.

• the poison must not get thrown to enemy base. it will do spawnkill
• the poison has punch image for kill log
• The inventory texture could be a lot greener
• The smoke color could be a little stronger
• Should be disabled around enemy bases, and/or maybe have a reduced lifetime
• Doesn't spawn in classes/nade_fight treasure chests

[LoneWolfHT]

Your PRs keep getting worse and worse baggage-wise.

You didn't base this PR off of the parent repo's master, so your team spike changes are included in this PR.
You also still have the map submodule issue, it would be nice if we could figure out how to fix that

[farooqkz]

Your PRs keep getting worse and worse baggage-wise.

lol. My apologies! Perhaps I'm too much in a hurry or perhaps I'm overloading myself.

You didn't base this PR off of the parent repo's master, so your team spike changes are included in this PR. You also still have the map submodule issue, it would be nice if we could figure out how to fix that

Well I did git checkout -b poison up/master where up is the upstream. Perhaps I've been doing so wrong all the time?

[farooqkz]

Ready for another review

[LoneWolfHT]

Nice, it worked.

There should be no nodes/abms involved in this.
Get the poison grenade explosion pos and check it against the position of all online players in a minetest.after(1) loop that stops when the smoke does

[farooqkz]

Nice, it worked.

There should be no nodes/abms involved in this. Get the poison grenade explosion pos and check it against the position of all online players in a minetest.after(1) loop that stops when the smoke does

May I ask why?

[LoneWolfHT]

May I ask why?

ABMs are terribly inefficient, and temporary nodes like your poison one should be avoided whenever possible, since they rely on the explosion area meeting certain conditions (like not being underwater or containing nodes with non-default collisionboxes), and there are usually faster solutions

[farooqkz]

May I ask why?

ABMs are terribly inefficient, and temporary nodes like your poison one should be avoided whenever possible, since they rely on the explosion area meeting certain conditions (like not being underwater or containing nodes with non-default collisionboxes), and there are usually faster solutions

I'm stuck here. See my latest commit.

[LoneWolfHT]

You got quite far, nice work

[farooqkz]

It's working now \o/

[farooqkz]

I don't check Discord anymore. Please let me know regarding the test session(when and where).

[LoneWolfHT]

It'll probably take a while. I need to finish working on something else that I want to test

[farooqkz]

You want to test this and that together?

[LoneWolfHT]

@farooqkz What timezone are you in, and what would an ideal testing time be?

[farooqkz]

@farooqkz What timezone are you in, and what would an ideal testing time be?

The ideal time window for me would be about 12-18(UTC)

[farooqkz]

@LoneWolfHT When is the testing session? or perhaps yet undecided?

[LoneWolfHT]

14:30 UTC on February 27
Are you able to talk on Discord when the time arrives?

[farooqkz]

14:30 UTC on February 27 Are you able to talk on Discord when the time arrives?

The time seems okay for me. But I won't be able to log into Discord anytime soon.

[LoneWolfHT]

14:30 UTC on February 27 Are you able to talk on Discord when the time arrives?

The time seems okay for me. But I won't be able to log into Discord anytime soon.

How about IRC/Matrix?
If not those then you'll have to join the main server for the address/port I guess

[farooqkz]

14:30 UTC on February 27 Are you able to talk on Discord when the time arrives?

The time seems okay for me. But I won't be able to log into Discord anytime soon.

How about IRC/Matrix? If not those then you'll have to join the main server for the address/port I guess

I am available on them.

[LoneWolfHT]

1. the poison must not get thrown to enemy base. it will do spawnkill

2. the poison has punch image for kill log

3. The inventory texture could be a lot greener

4. The smoke color could be a little stronger

5. Should be disabled around enemy bases, and/or maybe have a reduced lifetime

6. Doesn't spawn in classes/nade_fight treasure chests

[farooqkz]

Regarding kill log, I need some hints. And what do you mean the colour must be stronger?

[LoneWolfHT]

And what do you mean the colour must be stronger?

It should be less grey/have more color to it

You can change the kill log image in this function: https://github.com/MT-CTF/capturetheflag/blob/master/mods/ctf/ctf_modebase/features.lua#L23-L46

[LoneWolfHT]

Added the TODO list to the main post

[farooqkz]

@LoneWolfHT ready for review

[LoneWolfHT]

the poison has punch image for kill log

This wasn't fixed. I've done so in f4a8d72