Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show classes about info even during cooldown period. #1320

Merged
merged 8 commits into from
Jun 29, 2024
Merged

Show classes about info even during cooldown period. #1320

merged 8 commits into from
Jun 29, 2024

Conversation

mrtechtroid
Copy link
Contributor

@mrtechtroid mrtechtroid commented Jun 29, 2024 •
edited
Loading

  • This PR has been tested locally
  • Based on suggestion on Discord shows the classes info even if the player is in cooldown.
  • If in cooldown period, the regular button_exit is replaced with button with red text, and it shows the classes info instead of switching you to the class. (Similar behaviour as info button)
    image

farooqkz
farooqkz suggested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@farooqkz farooqkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpicks, it looks good to me overall

mods/ctf/ctf_modes/ctf_mode_classes/classes.lua Outdated Show resolved Hide resolved
mods/ctf/ctf_modes/ctf_mode_classes/classes.lua Outdated Show resolved Hide resolved
LoneWolfHT
LoneWolfHT requested changes Jun 29, 2024
View reviewed changes
Copy link
Member

@LoneWolfHT LoneWolfHT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just delete code that's not used anymore. git saves it for you

mods/ctf/ctf_modes/ctf_mode_classes/classes.lua Outdated Show resolved Hide resolved
mods/ctf/ctf_modes/ctf_mode_classes/classes.lua Outdated Show resolved Hide resolved
@LoneWolfHT LoneWolfHT merged commit c834d6e into MT-CTF:master Jun 29, 2024
1 check passed
@mrtechtroid mrtechtroid deleted the mtt-2906 branch August 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farooqkz farooqkz farooqkz requested changes

@LoneWolfHT LoneWolfHT LoneWolfHT requested changes

Assignees
No one assigned
Labels
Action / change needed ❗ Feature ⭐ ⚙️ Classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrtechtroid @farooqkz @LoneWolfHT