Add classes

[rubenwardy]

Please note that you need to apply an engine patch in order to have accurate health bar points.

[ClobberXD]

Couple of comments. I understand that this is still WIP, but I couldn't resist. :)

I also think it's better to rename the knight and archer classes to more generic names (at least the archer). Maybe assault and support? We don't even have bows in the game, and referring to players wielding sniper rifles as archers is a little misleading. ;)

[ClobberXD]

I'm very happy to see an effort being made in this direction. Great work. 👍

[ClobberXD]

• I see lotsa colour hardcoding. :/

  I suggest having neutral textures, and applying texture modifiers based on team colour.

• The classes API could be improved by allowing ctf_classes.register to take a table as param, which lists all properties of that class. e.g.

  ctf_classes.register("new_class", {
    description = "New class",
    properties = {
    	speed = 1,
    	max_hp = 20,
    	-- More properties that can be thought of later
    }
  }

• Currently, right-clicking the flags opens up a news panel, which is only really useful for long-term kingdom vs kingdom games. I suggest adding the ability for players to open the classes formspec by right-clicking on the flag.

[ClobberXD]

Unrelated commits: 8c399ee and 1a13fcb. These are already a part of master. So... remove these from this PR?

[rubenwardy]

I see lotsa colour hardcoding. :/

I suggest having neutral textures, and applying texture modifiers based on team colour.

This is inflexible and also more complicated. Hardcoding can be good at reducing complexity. However it's a good idea to reduce the number of places which have hardcoded things, which is why, for example, we use ctf_color.get_color rather than just have if statements everywhere

The classes API could be improved by allowing ctf_classes.register to take a table as param, which lists all properties of that class. e.g.

This already happens, see init.lua

Currently, right-clicking the flags opens up a news panel, which is only really useful for long-term kingdom vs kingdom games. I suggest adding the ability for players to open the classes formspec by right-clicking on the flag.

This already happens

[ClobberXD]

Currently, right-clicking the flags opens up a news panel, which is only really useful for long-term kingdom vs kingdom games. I suggest adding the ability for players to open the classes formspec by right-clicking on the flag.

This already happens

I missed that change. Nice! 👍

The classes API could be improved by allowing ctf_classes.register to take a table as param, which lists all properties of that class. e.g.

This already happens, see init.lua

I think you misunderstood. See https://github.com/MT-CTF/capturetheflag/pull/389/files#diff-162a1d6f9c661726680d0f44a5e8d794R15-R16. speed and max_hp are defined outside the table as special properties, and the table itself contains only a list of descriptions (be it pros or cons). I meant something like the following:

ctf_classes.register("knight", {
	description = "Knight",
	pros = { "+50% Health Points" },
	cons = { "-10% speed" },
	properties = {
		max_hp = 30,
		speed = 0.90
	},
	color = "#ccc",
})

This approach can allow more properties to be added later, because all fields in properties table are parsed instead of two hard-coded fields speed and max_hp. This requires more coding though and can be implemented later if required - I think this is fine as it is at the moment.

[JostP]

Maybe it would be good if guns had longer range for archers. Shotgun has range only 50 currently.

[ClobberXD]

Maybe it would be good if guns had longer range for archers. Shotgun has range only 50 currently.

A range of 50 is already too much. A shotgun is only effective at close-range, and at 50m the pellets would've dispersed so much that there would be no substantial damage to the target anyway.

If you take other guns into consideration, well there's only so far we can see without in MT without zoom. Unless you have an 8K display fitted with an electron microscope, a very high range won't make much sense. ;)

[rubenwardy]

This is now ready for review, and I've tested all the features locally

[JostP]

Do medic have free bandages?

[rubenwardy]

grenades are infinite

turns out creative was enabled 😮

[rubenwardy]

Bugs

general

• spawned with steel sword as sharp shooter (I can't reproduce this)
• can't change class on captured top of flag
• broken GUI for change class

grapples

• Shooting just a grapple gives many more uses than shooting with a gun
• empty grapple and hooks aren't removed on death. Same for putting in a chest etc
• grappling hooks don't work on slabs
• grappling hooks can fly off and disappear
• can throw hooks when holding the flag
• can grapple into a one node tall space
• grapple hooks can be used by more than just shooters

Future

Things to fix in future PRs

• infinite ammo for rifle
• more damage for guns with shooter
• change medic to support, ammo regen
• add crafting of rockets
• -20% when rocket launcher is equiped
• prevent other classes from using rocket launcher