Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add map based fitting #123

Merged
merged 2 commits into from
Feb 10, 2025
Merged

feat!: add map based fitting #123

merged 2 commits into from
Feb 10, 2025

Conversation

skhrg
Copy link
Collaborator

@skhrg skhrg commented Feb 8, 2025

Two remaining issues to fix to merge in:

  1. RXJ1437 seems to not be in the act map I'm using, @Sulla2012 can you take a look and see if you can make one? I may be using the wrong map?
  2. MCMC fails, will continue to debug. It is possible something in the mcmc_fixes branch also may fix so once that is merged into main I'll rebase that onto this branch. This turned out to be me using too large of a step size

@skhrg skhrg marked this pull request as ready for review February 9, 2025 19:31
@skhrg
Copy link
Collaborator Author

skhrg commented Feb 9, 2025

@Sulla2012 think this is good to go now

@Sulla2012 Sulla2012 merged commit a7963a5 into main Feb 10, 2025
1 check passed
@Sulla2012 Sulla2012 deleted the map_fitting branch February 10, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants